Skip to content

Improve CLI error handling for missing required arguments #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SLohit448 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve CLI error handling for missing required arguments #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion fire/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,18 @@ def _CallAndUpdateTrace(component, args, component_trace, treatment='class',
# Event loop is already running
component = loop.run_until_complete(fn(*varargs, **kwargs))
else:
component = fn(*varargs, **kwargs)
try:
component = fn(*varargs, **kwargs)
except TypeError as e:
message = str(e)

if 'missing' in message and 'required positional argument' in message:
raise TypeError(
f"Error: {message}\n\n"
f"Hint: Run the command with --help to see usage."
) from None

raise

if treatment == 'class':
action = trace.INSTANTIATED_CLASS
Expand Down