Fix parseEscape to support only ASCII values#183
Open
le0pard wants to merge 1 commit intogoogle:masterfrom
Open
Fix parseEscape to support only ASCII values#183le0pard wants to merge 1 commit intogoogle:masterfrom
le0pard wants to merge 1 commit intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on golang parser code, one condition was missed, that is why some regex was marked as is valid, when it is not
P.S. in golang
utf8.RuneSelf == 0x80, but hereUnicode.MAX_ASCII == 0x7f, that is why<=in condition