Matcher: no useless backtracking in group replace#190
Open
kitbellew wants to merge 1 commit intogoogle:masterfrom
Open
Matcher: no useless backtracking in group replace#190kitbellew wants to merge 1 commit intogoogle:masterfrom
kitbellew wants to merge 1 commit intogoogle:masterfrom
Conversation
When encountering `${`, we do not move the read index forward to the `}`
and continue iterating on it again.
The reason it "worked" is two-fold:
- a group name contains alphanumeric or underscore, which won't trigger
special handling in the loop (only `\\` and `$` would)
- we had already moved `last` index past the closing `}`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering
${, we do not move the read index forward to the}and continue iterating on it again.The reason it "worked" is two-fold:
\\and$would)lastindex past the closing}Helps with #187.