Skip to content

Security: Restore password authentication for EncodingServer #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r3352 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security: Restore password authentication for EncodingServer #513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions java/sage/EncodingServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,16 +229,24 @@ public void run()
//mySock.setTcpNoDelay(true);
outStream = new java.io.DataOutputStream(new java.io.BufferedOutputStream(mySock.getOutputStream()));
inStream = new java.io.DataInputStream(new java.io.BufferedInputStream(mySock.getInputStream()));
/* String pass = Sage.readLineBytes(inStream);
if (!pass.equalsIgnoreCase(Sage.get(ENCODING_SERVER_PASSWORD_MD5, "")))
{
outStream.write("INVALID_PASSWORD\r\n".getBytes(Sage.CHARSET));
outStream.flush();
}
else // valid password, accept the encoding command
*/
// outStream.write("OK\r\n".getBytes(Sage.CHARSET));
// outStream.flush();
String configuredPass = Sage.get(ENCODING_SERVER_PASSWORD_MD5, "");
if (configuredPass.length() > 0)
{
String pass = Sage.readLineBytes(inStream);
if (!pass.equalsIgnoreCase(configuredPass))
{
outStream.write("INVALID_PASSWORD\r\n".getBytes(Sage.BYTE_CHARSET));
outStream.flush();
if (Sage.DBG) System.out.println("EncodingServer auth failed, closing connection from " + mySock);
return;
}
else
{
outStream.write("OK\r\n".getBytes(Sage.BYTE_CHARSET));
outStream.flush();
if (Sage.DBG) System.out.println("EncodingServer auth succeeded from " + mySock);
}
}
while (true)
{
String str = Sage.readLineBytes(inStream);
Expand Down