This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Conversation
mattn
commented
Oct 4, 2017

Contributor
|
Hi Matt, thanks for contributing this change. I'm not sure yet where this feature belongs as it doesn't relate specifically to the Go implementation of Skylark, but various possible alternative locations are equally unnecessarily tied to the Java implementation. It seems we need a place for implementation-language-agnostic helper programs like this one. I'm discussing it with the Bazel team and will let you know what we conclude. More specifically, I wonder whether this change is necessary at all. Syntactically, Skylark is a strict subset of Python, so I would expect Skylark to be well supported by all existing editors if they simply treat it as Python. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.