Modern cmake

[craffael]

I don't know if you are interested in CMake support for TcMalloc. I recently had come up with this in order to use TcMalloc with the rest of my codebase and I thought you might be interested (?).

• The setup is very similar to abseil: there is a tcmalloc_cc_library function which takes almost the same arguments as absl_cc_library
• One difficulty was the implementation of alwayslink from bazel. I solved this by using a recent feature of CMake 3.21 (https://cmake.org/cmake/help/v3.22/command/target_link_libraries.html#linking-object-libraries-via-target-objects). Because of this CMake 3.21 or higher is required.
• So far there is no documentation on how to use CMake. If you are interested, I can add this?
• Because TcMalloc requires Abseil, a CMake installation of abseil must be present on the system and set with the cmake variable absl_DIR.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[craffael]

@googlebot I signed it!

[gjasny]

Suggested change

	install(EXPORT tcmallocTargets DESTINATION ${config_install_dir} NAMESPACE tcmalloc::)
	install(EXPORT ${PROJECT_NAME}Targets DESTINATION ${config_install_dir} NAMESPACE tcmalloc::)

[gjasny]

Suggested change

	install(FILES ${TCMALLOC_CC_LIB_HDRS} DESTINATION "include/tcmalloc")
	install(FILES ${TCMALLOC_CC_LIB_HDRS} DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/tcmalloc")

[oontvoo]

Hi, any plan to move forward with this PR? @ckennelly Thanks!

[craffael]

I'm currently on holidays. I will get back to you guys in about two weeks...

[leo-128t-liu]

@craffael Appreciate the work to put this together! Could you please also add the doc to show how to use the CMake to build a shared lib of tcmalloc?
Thanks!

[hdu-sdlzx]

@craffael still working on this PR?

[leo-128t-liu]

I have got it working and integrated the latest branch with cmake. What issue are you running into? Your build environment should meet the requirements in CMake and g++ or clang version.

[yiguolei]

Any progress on this PR? I want to use the latest TcMalloc in Apache Doris apache/doris#9580.

[ObiWahn]

https://github.com/ObiWahn/tcmalloc-cmake

If I look at your code, then I see that a lot needs to be done on my side :)

[stonebrakert6]

Any hope of seeing this? Bazel is too big of a requirement for someone who just wants

1. To use this library
2. generate compile_commands.json(compilation DB) for lsp
   I believe bazel doesn't natively support generation of compile_commands.json and bear doesn't work with bazel
   What do googlers use to generate compilation database(compile_commands.json) when your project is built using bazel ? Do you guys use this

[gtkramer]

@stonebrakert6 raises a good point--any project that wants to use this today MUST use Bazel, which is restrictive and sometimes not possible. Having a way to precompile this library and install it with lib and include folders would go a long way to making this easier to adopt in a project, especially if the project is also CMake based (as many MANY are).

[JackBoosY]

Is this PR still WIP?