Skip to content

Conversation

@aolemila
Copy link
Collaborator

@aolemila aolemila commented Feb 3, 2026

Resolves #1040.

python3 scripts/grpo_demo_llama3_qwen2.py --num-batches 2 --num-test-batches 1 --root-dir=/home/gcpuser/aolemila --rollout-engine sglang_jax --sglang-jax-log-level debug

image image

It's a good idea to open an issue first for discussion.

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and all unit tests pass.
  • I have added all appropriate doc-strings/documentation.
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have signed the Contributor License Agreement.
  • I have followed Contribution Guidelines.

@gemini-code-assist
Copy link

Summary of Changes

Hello @aolemila, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option to control the logging verbosity of the Sglang JAX rollout engine. By adding a log_level parameter to relevant configuration classes, users can now specify the desired logging output, improving debugging and operational visibility without altering core logic.

Highlights

  • SglangJaxConfig Update: Introduced a new log_level field with a default value of "info" to the SglangJaxConfig class, allowing configuration of logging verbosity for the Sglang JAX engine.
  • RolloutConfig Enhancement: Added rollout_sglang_jax_log_level to the RolloutConfig class, providing a dedicated configuration option for the Sglang JAX rollout engine's logging level.
  • SglangJaxSampler Integration: Modified the SglangJaxSampler initialization to accept and utilize the newly introduced log_level from the RolloutConfig, ensuring the configured logging level is applied.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tunix/generate/sglang_jax_sampler.py
    • Added log_level: str = "info" to the SglangJaxConfig class.
    • Mapped the config.log_level to args["log_level"] within the _sglang_jax_config method.
  • tunix/rl/rollout/base_rollout.py
    • Added rollout_sglang_jax_log_level: str = "info" to the RolloutConfig class.
  • tunix/rl/rollout/sglang_jax_rollout.py
    • Passed rollout_config.rollout_sglang_jax_log_level as the log_level argument to the SglangJaxSampler constructor.
Activity
  • The pull request aims to resolve issue [Tiny Feat] make log_level be configurable #1040.
  • The author has provided a checklist for contribution guidelines, indicating adherence to project standards.
  • No specific review comments or discussions have been provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration option, rollout_sglang_jax_log_level, to control the logging verbosity of the SGLang JAX rollout engine. The change is well-implemented, correctly passing the setting from RolloutConfig through to the SglangJaxSampler. The code is clean and follows existing patterns. I have one minor suggestion to improve the clarity of a comment, in line with the repository's style guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tiny Feat] make log_level be configurable

1 participant