Skip to content

[agents] Update review guidelines for TODOs #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshlf merged 1 commit into from
Feb 2, 2026
Merged

[agents] Update review guidelines for TODOs #2967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions agent_docs/reviewing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,14 @@ resolved. When you encounter a `TODO` comment:
be resolved*.
2. **Critique** only if the `TODO` is insufficient (i.e., the code would still
be problematic *even if* the `TODO` were resolved).
3. **Safety Placeholders:** A `// SAFETY: TODO` comment is a valid placeholder
for a safety comment, and a `/// TODO` comment in a `/// # Safety` doc
section is a valid placeholder for safety documentation. **DO NOT** flag
the first as a missing safety justification or a critical issue, and **DO
NOT** flag the second as missing safety documentation. You must assume the
author will write a sound justification or accurate safety documentation
before merging.

<!-- TODO-check-enable -->

## 4. Anti-Patterns (NEVER Do This)
Expand Down
Loading