Conversation
Refactors the Miri test execution in `.github/workflows/ci.yml` to run Stacked Borrows and Tree Borrows tests in parallel. This is achieved by: 1. Launching both `cargo miri nextest` commands as background jobs. 2. Assigning a unique `CARGO_TARGET_DIR` to each job (`target/by-toolchain/$TOOLCHAIN/miri-stacked` and `...-tree`) to prevent build directory lock contention. 3. Redirecting stdout/stderr to log files to avoid interleaved output. 4. Waiting for both jobs to complete, printing their logs, and propagating exit codes. This change significantly reduces the wall-clock time for the Miri CI step. Co-authored-by: joshlf <1046063+joshlf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 20 20
Lines 6057 6057
=======================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This PR updates the CI workflow to run Miri tests (Stacked Borrows and Tree Borrows) in parallel. This is done by spawning background processes with distinct
CARGO_TARGET_DIRs to avoid lock contention. Logs are captured to files and printed after execution to ensure readability. This optimization should reduce the Miri step duration by approximately 50%.PR created automatically by Jules for task 1531335339501971407 started by @joshlf