Skip to content
This repository was archived by the owner on Aug 13, 2022. It is now read-only.

Add .gitignore and switch to AndroidX#105

Open
ufoq wants to merge 3 commits intogoogleads:mainfrom
ufoq:androidx
Open

Add .gitignore and switch to AndroidX#105
ufoq wants to merge 3 commits intogoogleads:mainfrom
ufoq:androidx

Conversation

@ufoq
Copy link
Copy Markdown

@ufoq ufoq commented Mar 30, 2020

Most of users use this lib together with ads libs that already use AndroidX and it may be troublesome to keep old appcompat working with AndroidX, that's why it's better to just switch to it.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ufoq
Copy link
Copy Markdown
Author

ufoq commented Mar 30, 2020

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ufoq
Copy link
Copy Markdown
Author

ufoq commented Mar 30, 2020

BTW it's weird to have dependency on appcompat just for annotations, maybe switching 'implementation' to 'testImplementation' is enough (this way there will be no dependency problems no matter what lib dev will use). I can make PR if you want.

@chrisgiglio chrisgiglio changed the base branch from master to main March 4, 2022 00:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants