fix: update dependency io.grpc:grpc-bom to v1.80.0#767
fix: update dependency io.grpc:grpc-bom to v1.80.0#767renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
c1eeddf to
a5d429f
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the io.grpc:grpc-bom dependency from version 1.79.0 to 1.80.0. While this is a minor update, it highlights a potential risk in the existing code. The application uses an internal, experimental gRPC API (BlockingClientCall), which is not guaranteed to be stable across versions. This dependency update could introduce runtime breakages. I've added a comment with a recommendation to refactor this for better long-term stability.
| <groupId>io.grpc</groupId> | ||
| <artifactId>grpc-bom</artifactId> | ||
| <version>1.79.0</version> | ||
| <version>1.80.0</version> |
There was a problem hiding this comment.
This gRPC version update introduces a potential risk. The codebase in GrpcSpannerLibraryImpl.java on line 242 uses io.grpc.stub.BlockingClientCall, which is an internal gRPC API and marked as experimental. Internal APIs are not guaranteed to be stable and can change without notice between versions, which could cause this update to break functionality at runtime. It is highly recommended to refactor the code to avoid using internal gRPC APIs and rely only on the public, stable API surface.
This PR contains the following updates:
1.79.0→1.80.0Release Notes
grpc/grpc-java (io.grpc:grpc-bom)
v1.80.0Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.