Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spannerlib/wrappers/spannerlib-java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-bom</artifactId>
<version>1.80.0</version>
<version>1.81.0</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating grpc-bom to 1.81.0 while maintaining hardcoded versions for netty-transport-native-epoll (4.2.12.Final) and protobuf-bom (4.34.1) creates a high risk of runtime binary incompatibilities. gRPC 1.x is generally incompatible with Netty 4.2.x and requires specific Protobuf versions. Per repository guidelines, when updating dependencies not managed by a BOM, verify the version's release date and compatibility with other libraries. Furthermore, because grpc-bom is imported after google-cloud-spanner-bom, Maven's 'first-declaration-wins' rule may cause some gRPC artifacts to use older versions. Consider removing explicit versions for Netty and Protobuf to allow the BOMs to manage them, and ensure grpc-bom is declared before other BOMs.

References
  1. When updating dependencies, especially those not managed by a BOM, verify the version's release date to ensure it is current and compatible with other libraries.

<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
Loading