Skip to content

fix(storage): standardize URL construction to use v1 API paths#8191

Open
thiyaguk09 wants to merge 2 commits intogoogleapis:storage-node-18from
thiyaguk09:fix/storage-v1-url-formatting
Open

fix(storage): standardize URL construction to use v1 API paths#8191
thiyaguk09 wants to merge 2 commits intogoogleapis:storage-node-18from
thiyaguk09:fix/storage-v1-url-formatting

Conversation

@thiyaguk09
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@thiyaguk09 thiyaguk09 requested a review from a team as a code owner May 6, 2026 14:43
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label May 6, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the library to use versioned API paths (/storage/v1) across all storage resources and standardizes the use of JSON content-type headers. It also refactors the File.isPublic method and the Iam class. Review feedback identifies a regression in the isPublic refactor where interceptors are no longer applied, a potential URL construction issue regarding the apiEndpoint protocol, and a recommendation to replace 'any' types with specific interfaces for better type safety.

Comment thread handwritten/storage/src/file.ts
Comment thread handwritten/storage/src/file.ts Outdated
Comment thread handwritten/storage/src/iam.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant