This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Feat: adds credentials and project properties to BigQueryClient#2276
Closed
chalmerlowe wants to merge 1 commit into
Closed
Feat: adds credentials and project properties to BigQueryClient#2276chalmerlowe wants to merge 1 commit into
chalmerlowe wants to merge 1 commit into
Conversation
chalmerlowe
requested review from
a team and
tswast
and removed request for
a team
product-auto-label
Bot
added
size: m
Collaborator
Author
|
Need to add unit tests for this functionality. |
tswast
reviewed
Sep 4, 2025
| /en/latest/user-guide.html#obtaining-credentials | ||
| """ | ||
| if self._properties["credentials"] is None: | ||
| self._properties["credentials"], _ = google.auth.default() |
Contributor
There was a problem hiding this comment.
google.auth can be a relatively expensive call. Many years ago, it was regularly taking 30+ seconds. It's thankfully usually faster than that, but still is something we should aim to do once if possible.
Collaborator
Author
|
Overtaken by events. Superceded by another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the credentials and project property to the BigQueryClient class as a response to a comment on a previous PR.
Project: Comment about making
projecta propertyCredentials: Comment about adding credentials