Skip to content

fix: handle separate workspace release PRs - #2859

Open
flandia wants to merge 2 commits into
googleapis:mainfrom
flandia:agent/fix-separate-workspace-candidates
Open

fix: handle separate workspace release PRs#2859
flandia wants to merge 2 commits into
googleapis:mainfrom
flandia:agent/fix-separate-workspace-candidates

Conversation

@flandia

@flandia flandia commented Jul 25, 2026

Copy link
Copy Markdown

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2853 🦕

  • attach each dependency-bump manifest entry to its corresponding workspace
    candidate when merge: false
  • preserve the combined manifest update when workspace candidates are merged
  • propagate configured release PR labels to candidates created by workspace
    plugins
  • add regression coverage for separate dependency-only candidates

The workspace plugin unconditionally attached the complete
updatedPathVersions map to newCandidates[0]. This was valid after merging
candidates, but with merge: false it placed every manifest entry in the first
PR and left the other dependency-bump PRs without manifest updates.

Workspace-created candidates also did not receive the labels configured by the
manifest, making them invisible to release and open-PR discovery logic.

@flandia
flandia requested review from a team as code owners July 25, 2026 06:27
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jul 25, 2026
@google-cla

google-cla Bot commented Jul 25, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@flandia

flandia commented Jul 25, 2026

Copy link
Copy Markdown
Author

Just signed the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node-workspace with merge: false: manifest updates go to the first candidate only, and plugin-created PRs are missing the autorelease label

1 participant