chore: update ruby version, audit some cops#88
Merged
viacheslav-rostovtsev merged 3 commits intogoogleapis:mainfrom Apr 28, 2025
Merged
Conversation
dazuma
reviewed
Apr 25, 2025
| Style/ReturnNilInPredicateMethodDefinition: | ||
| Enabled: true | ||
|
|
||
| Style/SafeNavigationChainLength: # new in 1.68 |
Contributor
There was a problem hiding this comment.
Can you provide a short note explaining why we want to disable this one?
| Lint/NumberedParameterAssignment: | ||
| Enabled: true | ||
|
|
||
| # Can easily appear in the generated code |
Contributor
There was a problem hiding this comment.
We do run a pass of rubocop -a in the generator. Is this insufficient to remove cases of this and some of the others below?
Member
Author
There was a problem hiding this comment.
I don't see the benefit of doing this as I barely agree that having += 0 in the codebase is problematic.
Contributor
|
We'll also need to remove ruby 3.0 from the CI matrix. |
dazuma
approved these changes
Apr 28, 2025
Contributor
dazuma
left a comment
dazuma
left a comment
There was a problem hiding this comment.
Okay let's give this a shot. When you merge, make sure you use feat: so release-please will offer to release a minor version (1.31.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.