This repository was archived by the owner on Apr 23, 2021. It is now read-only.
passing URLs in correct way; this solves issue #12#13
Open
dmitri777 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #12 is actually not a bug in library code.
The error happens because usage sample code is wrong. URLs are passed as strings in sample code, but they must be in fact dictionaries with src attribute, as can be seen from line 14 of https://github.com/GoogleChrome/apps-resource-loader/blob/master/lib/RAL/Image.js
This ways, it works fine. I tested in on my own Chrome App which is not published yet. Images were retrieved from the net and appended to target container w/o issues.