Skip to content

feat(GooglePlacesSwiftXCFrameworkDemos): read API key from Secrets.xcconfig [5/8] - #32

Merged
iHackSubhodip merged 1 commit into
SB/feature/places-demos-secretsfrom
SB/feat/swift-xcframework-secrets
Jul 29, 2026
Merged

feat(GooglePlacesSwiftXCFrameworkDemos): read API key from Secrets.xcconfig [5/8]#32
iHackSubhodip merged 1 commit into
SB/feature/places-demos-secretsfrom
SB/feat/swift-xcframework-secrets

Conversation

@iHackSubhodip

Copy link
Copy Markdown
Collaborator

What

  • Deletes tracked SDKDemoAPIKey.swift; reads PLACES_API_KEY from the bundle via
    Bundle.main.object(forInfoDictionaryKey:), fail-closed.
  • Adds tracked GooglePlacesSwiftXCFrameworkDemos.xcconfig wrapper (#include? "Secrets.xcconfig").
  • Info.plist maps PLACES_API_KEY$(PLACES_API_KEY).
  • project.pbxproj: wires the wrapper as a project-level base configuration.

Why

  • Removes the key from a tracked source file; CocoaPods-safe (project-level base
    config survives pod install).
  • Unifies onto the shared PLACES_API_KEY + Secrets.xcconfig mechanism.

When

Testing

  • Open GooglePlaces-Swift.xcworkspace, add GooglePlacesSwiftXCFrameworkDemos/Secrets.xcconfig
    with PLACES_API_KEY = … → launches; remove it → builds, fail-closed.
Screenshot 2026-07-29 at 5 52 43 PM
Simulator.Screen.Recording.-.iPhone.17.-.2026-07-29.at.17.41.17.mov

@iHackSubhodip
iHackSubhodip merged commit 4d4ece2 into SB/feature/places-demos-secrets Jul 29, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants