Skip to content

(chore): removed unused preamble variable, systemInstructions is enough. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caio1985 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(chore): removed unused preamble variable, systemInstructions is enough. #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf1473a
(chore): removed unused preamble variable, systemInstructions is enough.
caio1985 Dec 11, 2025
4e185f3
test: remove preamble from mock API responses and expected instructio…
caio1985 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/code-assist/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ export async function getUsageInstructions(server: Server) {

usageInstructions = [
ragResponse.data.systemInstructions,
ragResponse.data.preamble,
ragResponse.data.europeanEconomicAreaTermsDisclaimer
];

Expand Down
4 changes: 0 additions & 4 deletions packages/code-assist/tests/unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ describe("Google Maps Platform Code Assist MCP Server", () => {
const mockResponse = {
data: {
systemInstructions: "system instructions",
preamble: "preamble",
europeanEconomicAreaTermsDisclaimer: "disclaimer",
},
};
Expand All @@ -51,7 +50,6 @@ describe("Google Maps Platform Code Assist MCP Server", () => {

expect(instructions).toEqual([
"system instructions",
"preamble",
"disclaimer",
]);

Expand Down Expand Up @@ -106,7 +104,6 @@ describe("Google Maps Platform Code Assist MCP Server", () => {
const mockResponse = {
data: {
systemInstructions: "system instructions",
preamble: "preamble",
europeanEconomicAreaTermsDisclaimer: "disclaimer",
},
};
Expand All @@ -128,7 +125,6 @@ describe("Google Maps Platform Code Assist MCP Server", () => {
const mockResponse = {
data: {
systemInstructions: "system instructions",
preamble: "preamble",
europeanEconomicAreaTermsDisclaimer: "disclaimer",
},
};
Expand Down
Loading