docs(drive): add shared drives tip to SKILL.md#711
docs(drive): add shared drives tip to SKILL.md#711nuthalapativarun wants to merge 4 commits intogoogleworkspace:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 2a0144f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the usability of the Google Workspace CLI by enhancing documentation for shared drive operations and simplifying access to the Admin SDK Directory API. By adding clear examples for shared drive parameters and creating intuitive aliases for the Directory service, the changes reduce friction for users and agents interacting with these APIs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Google Drive documentation to include instructions for accessing files in shared drives using specific API parameters. It also introduces aliases for the Admin SDK Directory API along with corresponding unit tests. Feedback indicates that the addition of the Admin SDK aliases is considered scope creep and should be moved to a separate pull request to maintain focus.
Files in shared drives are not returned by default. Adds a 'Shared Drives' section with supportsAllDrives examples and a tip for agents to retry with the flag when a file cannot be found.
nuthalapativarun
force-pushed
the
docs/drive-shared-drives-tip
branch
from
62bb919 to
6079990
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a new section to the Google Drive skill documentation regarding shared drives, along with a changeset. The documentation explains how to use the supportsAllDrives and includeItemsFromAllDrives parameters. Feedback was provided to ensure the parameter syntax matches the JSON format required by the CLI and to clarify that includeItemsFromAllDrives is only valid for list operations to avoid potential errors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Google Drive skill documentation to include instructions on how to handle shared drives. It adds a new "Shared Drives" section to SKILL.md explaining the use of supportsAllDrives and includeItemsFromAllDrives parameters when files are not found in the default search. A corresponding changeset file has also been added. I have no feedback to provide.
…msFromAllDrives scope
- Intro text used URL-param style (supportsAllDrives=true); change to
JSON object style ("supportsAllDrives": true) to match --params format
- includeItemsFromAllDrives is only valid for files.list, not files.get;
note this in the tip to prevent parameter errors on get requests
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds documentation regarding shared drives in Google Drive, specifically updating SKILL.md to explain how to use the supportsAllDrives and includeItemsFromAllDrives parameters when searching for or retrieving files. A changeset file was also added to track these documentation changes. I have no feedback to provide.
2 participants
Summary
Closes #327
Files stored in a shared drive are invisible to
files listandfiles getby default. Agents searching for a file have no indication that they should retry withsupportsAllDrives: true, causing unnecessary back-and-forth with the user.This PR adds a Shared Drives section to
skills/gws-drive/SKILL.mdthat:supportsAllDrives: trueandincludeItemsFromAllDrives: trueChanges
skills/gws-drive/SKILL.md— new "Shared Drives" section with examples.changeset/docs-drive-shared-drives-tip.md— patch changeset