Skip to content

fix(deps): use workspace:^ for internal package dependencies - #681

Open
MaxLee-dev wants to merge 1 commit into
mainfrom
workspace-caret-deps
Open

fix(deps): use workspace:^ for internal package dependencies#681
MaxLee-dev wants to merge 1 commit into
mainfrom
workspace-caret-deps

Conversation

@MaxLee-dev

@MaxLee-dev MaxLee-dev commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Problem

워크스페이스 내부 패키지 의존성이 workspace:*로 고정되어 있었습니다. 배포된 버전에는 workspace:*가 아닌 고정된 버전으로 들어가게 됩니다.

예시 - @vapor-ui/core@1.5.0 package.json

 @vapor-ui/core@1.5.0 → @vapor-ui/hooks: 1.0.0-beta.6, @vapor-ui/icons: 1.2.1 (캐럿 없음)

이는 changeset에서 패치를 통해 릴리즈에 포함되어 있지 않은 종속 패키지도 함께 추가해서 버전이 변경되도록 설정되어 있기 때문.

Solution

@vapor-ui/hooks, @vapor-ui/icons, @vapor-ui/color-generator 의존성 명시자를 workspace:^로 변경해 배포 시 semver 범위가 적용되도록 했다. pnpm-lock.yaml도 함께 갱신했다.

Summary by CodeRabbit

  • 개선 사항
    • 패키지 간 의존성 버전 범위를 호환 가능한 마이너 버전 기준으로 조정했습니다.
    • 패키지 설치 및 업데이트 시 버전 관리의 일관성과 안정성이 향상되었습니다.

@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a927229

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vapor-ui Ready Ready Preview Aug 18, 2026 7:57am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b494b75a-cc09-43af-8c6d-1d793d99bd59

📥 Commits

Reviewing files that changed from the base of the PR and between 708bc37 and a927229.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml
📒 Files selected for processing (2)
  • packages/core/package.json
  • packages/css-generator/package.json

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

워크스페이스 의존성 범위를 workspace:*에서 workspace:^로 변경했습니다. 변경 대상은 packages/core의 두 의존성과 packages/css-generator의 한 의존성입니다.

Changes

워크스페이스 의존성 범위 조정

Layer / File(s) Summary
패키지 의존성 범위 업데이트
packages/core/package.json, packages/css-generator/package.json
@vapor-ui/hooks, @vapor-ui/icons, @vapor-ui/color-generator의 워크스페이스 의존성 범위를 workspace:^로 변경했습니다.

Estimated code review effort: 1 (매우 간단) | ~2분

Merge Risk: ⚪ Minimal · up to a9272

This PR updates internal package dependency ranges and the lockfile to preserve semver ranges in published packages; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 내부 패키지 의존성 범위를 workspace:*에서 workspace:^로 변경하는 주요 내용을 정확하고 간결하게 설명합니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch workspace-caret-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MaxLee-dev
MaxLee-dev marked this pull request as ready for review August 18, 2026 07:59
@MaxLee-dev
MaxLee-dev requested a review from noahchoii as a code owner August 18, 2026 07:59
@vapor-ui

Copy link
Copy Markdown
Collaborator

All tests passed!

Tests Passed Failed Duration Report
168 168 0 1m 17s Open report ↗︎

Click here if you need to update snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants