Open
Conversation
cloning the audio source element in Sound.
added 6 commits
November 15, 2017 16:25
It now uses a type (string 'ambisonic') and a order (number to define 1st, 2nd or 3rd order)
|
Benjamin Baudel, benjamin seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
added 5 commits
November 15, 2017 17:09
Contributor
|
Still WIP status.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in a story with multiple scenes using omnitone/ambisonic sounds the library is initialized at each scene on the first time we visit them and if we revisit them again it throws an error.
This PR fixes this problem.