feat(filters): adds mergeable reviewDecision composite value

Author: wgordon17

src/app/components/dashboard/PersonalSummaryStrip.tsx

@@ -91,8 +91,7 @@ export default function PersonalSummaryStrip(props: PersonalSummaryStripProps) {
     // Counts are computed from unfiltered data (ignoring scope, globalFilter, showPrRuns).
     // Click filters set scope=all so tabs don't hide items the count included.
     // Known approximations (single-value filter system cannot express these):
-    //   - "ready to merge": count requires reviewDecision=APPROVED||null, but filter
-    //     can't express OR — PRs with CHANGES_REQUESTED + passing CI may appear
+    //   - "ready to merge": uses composite reviewDecision=mergeable (APPROVED||null)
     //   - "awaiting review": count excludes self-authored PRs (!isAuthor), but
     //     role=reviewer filter includes them if user is both author+reviewer (rare)
     //   - globalFilter (org/repo) is NOT applied here — counts are persistent
@@ -130,6 +129,7 @@ export default function PersonalSummaryStrip(props: PersonalSummaryStripProps) {
         setTabFilter("pullRequests", "role", "author");
         setTabFilter("pullRequests", "draft", "ready");
         setTabFilter("pullRequests", "checkStatus", "success");
+        setTabFilter("pullRequests", "reviewDecision", "mergeable");
       },
     });
     if (prsBlocked > 0) items.push({

src/app/components/dashboard/PullRequestsTab.tsx

@@ -82,6 +82,7 @@ const prFilterGroups: FilterChipGroupDef[] = [
       { value: "APPROVED", label: "Approved" },
       { value: "CHANGES_REQUESTED", label: "Changes" },
       { value: "REVIEW_REQUIRED", label: "Needs review" },
+      { value: "mergeable", label: "Mergeable" },
     ],
   },
   {
@@ -213,7 +214,11 @@ export default function PullRequestsTab(props: PullRequestsTabProps) {
         if (!isEnriched && tabFilters.role === "author" && !roles.includes("author")) return false;
       }
       if (tabFilters.reviewDecision !== "all") {
-        if (pr.reviewDecision !== tabFilters.reviewDecision) return false;
+        if (tabFilters.reviewDecision === "mergeable") {
+          if (pr.reviewDecision !== "APPROVED" && pr.reviewDecision !== null) return false;
+        } else {
+          if (pr.reviewDecision !== tabFilters.reviewDecision) return false;
+        }
       }
       if (tabFilters.draft !== "all") {
         if (tabFilters.draft === "draft" && !pr.draft) return false;

src/app/stores/view.ts

@@ -16,7 +16,7 @@ const IssueFiltersSchema = z.object({
 const PullRequestFiltersSchema = z.object({
   scope: z.enum(["involves_me", "all"]).default("involves_me"),
   role: z.enum(["all", "author", "reviewer", "assignee"]).default("all"),
-  reviewDecision: z.enum(["all", "APPROVED", "CHANGES_REQUESTED", "REVIEW_REQUIRED"]).default("all"),
+  reviewDecision: z.enum(["all", "APPROVED", "CHANGES_REQUESTED", "REVIEW_REQUIRED", "mergeable"]).default("all"),
   draft: z.enum(["all", "draft", "ready"]).default("all"),
   checkStatus: z.enum(["all", "success", "failure", "pending", "conflict", "blocked", "none"]).default("all"),
   sizeCategory: z.enum(["all", "XS", "S", "M", "L", "XL"]).default("all"),

tests/components/dashboard/PersonalSummaryStrip.test.tsx

@@ -455,7 +455,7 @@ describe("PersonalSummaryStrip — click applies filters", () => {
     expect(viewState.tabFilters.pullRequests.reviewDecision).toBe("REVIEW_REQUIRED");
   });
 
-  it("clicking ready to merge sets scope=all, role=author, draft=ready, checkStatus=success", () => {
+  it("clicking ready to merge sets scope=all, role=author, draft=ready, checkStatus=success, reviewDecision=mergeable", () => {
     const onTabChange = vi.fn();
     const prs = [makePullRequest({ userLogin: "me", draft: false, checkStatus: "success", reviewDecision: "APPROVED" })];
 
@@ -469,6 +469,7 @@ describe("PersonalSummaryStrip — click applies filters", () => {
     expect(viewState.tabFilters.pullRequests.role).toBe("author");
     expect(viewState.tabFilters.pullRequests.draft).toBe("ready");
     expect(viewState.tabFilters.pullRequests.checkStatus).toBe("success");
+    expect(viewState.tabFilters.pullRequests.reviewDecision).toBe("mergeable");
   });
 
   it("clicking blocked sets scope=all, role=author, draft=ready, checkStatus=blocked", () => {
@@ -507,6 +508,8 @@ describe("PersonalSummaryStrip — count-to-filter contract", () => {
     makePullRequest({ id: 4, title: "Review PR", repoFullName: "org/repo-c", userLogin: "other-author", draft: false, checkStatus: "pending", reviewDecision: "REVIEW_REQUIRED", surfacedBy: ["other-author"], enriched: true, reviewerLogins: ["me"] }),
     // PR authored by me, draft with failing CI → NOT blocked (draft excluded)
     makePullRequest({ id: 5, title: "Draft PR", repoFullName: "org/repo-a", userLogin: "me", draft: true, checkStatus: "failure", reviewDecision: null, surfacedBy: ["me"], enriched: true, reviewerLogins: [] }),
+    // PR authored by me, passing CI, but CHANGES_REQUESTED → NOT ready to merge
+    makePullRequest({ id: 7, title: "Changes Requested PR", repoFullName: "org/repo-a", userLogin: "me", draft: false, checkStatus: "success", reviewDecision: "CHANGES_REQUESTED", surfacedBy: ["me"], enriched: true, reviewerLogins: [] }),
     // PR from tracked user, user not involved → only visible in scope=all
     makePullRequest({ id: 6, title: "Tracked PR", repoFullName: "org/repo-d", userLogin: "tracked-user", draft: false, checkStatus: "success", reviewDecision: "APPROVED", surfacedBy: ["tracked-user"], enriched: true, reviewerLogins: [] }),
   ];
@@ -598,6 +601,7 @@ describe("PersonalSummaryStrip — count-to-filter contract", () => {
     screen.getByText("Ready PR");
     expect(screen.queryByText("Conflict PR")).toBeNull();
     expect(screen.queryByText("Failing PR")).toBeNull();
+    expect(screen.queryByText("Changes Requested PR")).toBeNull();
   });
 
   it("'assigned' count matches IssuesTab filtered view", () => {

tests/components/dashboard/PullRequestsTab.test.tsx

@@ -532,3 +532,23 @@ describe("PullRequestsTab — checkStatus=blocked filter", () => {
     expect(screen.queryByText("Passing PR")).toBeNull();
   });
 });
+
+describe("PullRequestsTab — reviewDecision=mergeable filter", () => {
+  it("shows APPROVED and null-review PRs, excludes CHANGES_REQUESTED", () => {
+    const prs = [
+      makePullRequest({ id: 1, title: "Approved PR", repoFullName: "org/repo", reviewDecision: "APPROVED", surfacedBy: ["me"], enriched: true }),
+      makePullRequest({ id: 2, title: "No Review PR", repoFullName: "org/repo", reviewDecision: null, surfacedBy: ["me"], enriched: true }),
+      makePullRequest({ id: 3, title: "Changes PR", repoFullName: "org/repo", reviewDecision: "CHANGES_REQUESTED", surfacedBy: ["me"], enriched: true }),
+    ];
+    setTabFilter("pullRequests", "reviewDecision", "mergeable");
+    setAllExpanded("pullRequests", ["org/repo"], true);
+
+    render(() => (
+      <PullRequestsTab pullRequests={prs} userLogin="me" monitoredRepos={[]} />
+    ));
+
+    screen.getByText("Approved PR");
+    screen.getByText("No Review PR");
+    expect(screen.queryByText("Changes PR")).toBeNull();
+  });
+});