fix(config): prevents settings reset on partial update#34
Merged
wgordon17 merged 4 commits intogordon-code:mainfrom Mar 30, 2026
Merged
fix(config): prevents settings reset on partial update#34wgordon17 merged 4 commits intogordon-code:mainfrom
wgordon17 merged 4 commits intogordon-code:mainfrom
Conversation
- merges split solid-js/store imports in test file - trims redundant comment line in updateConfig - adds empty-object regression test for updateConfig - adds mixed valid/invalid field rejection test
Queries limit field from GraphQL rateLimit object and displays it dynamically in the footer. GitHub Enterprise Cloud orgs grant 10k pts/hr instead of the standard 5k, causing the old hardcoded display to show impossible values like 9000/5k/hr. Warning threshold is now proportional (< limit * 0.1) instead of hardcoded < 500. Adds safePositiveInt guard to reject 0/NaN/Infinity limit values with fallback to previous or 5000.
- inlines one-use keysProvided variable in updateConfig - adds updateRateLimitFromHeaders unit tests (valid, missing, malformed header) - adds safePositiveInt edge case tests (zero, negative limit fallback) - documents resetConfig() safety outside reactive root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary