fix(ui): corrects tab badge counts, toolbar layout, and ignore flash#42
Merged
wgordon17 merged 6 commits intogordon-code:mainfrom Apr 2, 2026
Merged
Conversation
- adds globalFilter (org/repo) to tabCounts memo so badges match displayed items - passes per-type ignored count to createReorderHighlight instead of total - makes getIgnoredCount parameter required, removes optional chaining - uses consistent block-form filter style across all tabCounts branches - adds comprehensive reorderHighlight tests covering suppression and resumption - adds tests for PR/run ignore badge decrement and showPrRuns toggle - uses precise digit-extraction assertions for badge count verification
Covers cor-1 fix: verifies tabCounts filters by viewState.globalFilter.repo
Covers QA domain review findings: lockedChanged branch coverage and org prefix filter path
PR/Actions un-ignore round-trip, showPrRuns+ignore combo, timer clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary