Skip to content

refactor(ui): replaces corvu Drawer with Kobalte Dialog #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgordon17 merged 3 commits into from
Apr 2, 2026
Merged

refactor(ui): replaces corvu Drawer with Kobalte Dialog #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd80c51
refactor(ui): replaces corvu Drawer with Kobalte Dialog
wgordon17 Apr 2, 2026
5fdc7a0
fix(a11y): adds Dialog.Description and idiomatic test query
wgordon17 Apr 2, 2026
e1ea995
fix(test): tightens NotificationDrawer assertions and adds coverage
wgordon17 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@octokit/plugin-throttling": "11.0.3",
"@sentry/solid": "10.46.0",
"@solidjs/router": "0.16.1",
"corvu": "0.7.2",
"idb": "8.0.3",
"solid-js": "1.9.11",
"zod": "4.3.6"
Expand Down
206 changes: 0 additions & 206 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 13 additions & 12 deletions src/app/components/shared/NotificationDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createMemo, For, Show } from "solid-js";
import Drawer from "corvu/drawer";
import { Dialog } from "@kobalte/core/dialog";
import {
getNotifications,
markAllAsRead,
Expand All @@ -25,15 +25,16 @@ export default function NotificationDrawer(props: NotificationDrawerProps) {
}

return (
<Drawer open={props.open} onOpenChange={(open) => !open && props.onClose()} side="right">
<Drawer.Portal>
<Drawer.Overlay class="fixed inset-0 bg-black/50 z-[70]" />
<Drawer.Content class="fixed top-0 right-0 h-full w-80 sm:w-96 bg-base-100 shadow-xl z-[71] flex flex-col">
<Dialog open={props.open} onOpenChange={(open) => !open && props.onClose()} modal>
<Dialog.Portal>
<Dialog.Overlay class="drawer-overlay fixed inset-0 bg-black/50 z-[70]" data-testid="notification-overlay" />
<Dialog.Content class="drawer-content fixed top-0 right-0 h-full w-80 sm:w-96 bg-base-100 shadow-xl z-[71] flex flex-col">
<Dialog.Description class="sr-only">Recent system notifications and errors</Dialog.Description>
{/* Header */}
<div class="flex items-center gap-2 px-4 py-3 border-b border-base-300 shrink-0">
<Drawer.Label class="text-lg font-semibold text-base-content flex-1">
<Dialog.Title class="text-lg font-semibold text-base-content flex-1">
Notifications
</Drawer.Label>
</Dialog.Title>
<button
type="button"
onClick={markAllAsRead}
Expand All @@ -48,7 +49,7 @@ export default function NotificationDrawer(props: NotificationDrawerProps) {
>
Dismiss all
</button>
<Drawer.Close
<Dialog.CloseButton
class="btn btn-ghost btn-sm btn-circle ml-1"
aria-label="Close notifications"
>
Expand All @@ -59,7 +60,7 @@ export default function NotificationDrawer(props: NotificationDrawerProps) {
clip-rule="evenodd"
/>
</svg>
</Drawer.Close>
</Dialog.CloseButton>
</div>

{/* Notification list */}
Expand Down Expand Up @@ -129,8 +130,8 @@ export default function NotificationDrawer(props: NotificationDrawerProps) {
</ul>
</Show>
</div>
</Drawer.Content>
</Drawer.Portal>
</Drawer>
</Dialog.Content>
</Dialog.Portal>
</Dialog>
);
}
Loading