feat(filters): compact filter popovers with global sort#53
Merged
wgordon17 merged 18 commits intogordon-code:mainfrom Apr 7, 2026
Merged
feat(filters): compact filter popovers with global sort#53wgordon17 merged 18 commits intogordon-code:mainfrom
wgordon17 merged 18 commits intogordon-code:mainfrom
Conversation
- removes orphaned sortPreferences schema field, SortPreference type, and _tabId parameter - adds globalSort to resetViewState, hoists globalSortOptions to module scope - replaces invalid role=listbox/option ARIA with aria-pressed on filter buttons - makes FilterBar sort props optional with Show guard - removes Tooltip wrapper from ScopeToggle, changes Reset all to btn-xs - inlines isValidUserFilter using local tabFilter snapshot - removes redundant sortPref createMemo passthrough in both tabs - adds tests for user-filter auto-reset, globalSort defaults, migration, scope-only active filter, stale value fallback, FilterBar sort rendering
wgordon17
force-pushed
the
worktree-compact-filter-popovers
branch
from
41a8153 to
4cd3f66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary