feat(ui): scroll lock fix + org-grouped accordion for 6+ orgs#54
Merged
wgordon17 merged 4 commits intogordon-code:mainfrom Apr 7, 2026
Merged
feat(ui): scroll lock fix + org-grouped accordion for 6+ orgs#54wgordon17 merged 4 commits intogordon-code:mainfrom
wgordon17 merged 4 commits intogordon-code:mainfrom
Conversation
- extracts withScrollLock to shared src/app/lib/scroll.ts with try/finally - adds withFlipAnimation (200ms ease-in-out, reduced-motion fallback) - replaces instant repo pin/move with FLIP animation via data-repo-group attrs - preserves scroll position on timed poll refresh in DashboardPage - refactors accordion: single bordered unit, inline Select/Deselect in header bar, loading spinner on collapsed headers, orgId sanitization for DOM IDs - refactors orgContent closure (removes isAccordion check), Show+fallback pattern - adds 12 new tests (1573 total, 71 files, typecheck clean)
- Replaces custom accordion with @kobalte/core Accordion (aria, keyboard nav, heading semantics via h3) - Extracts OrgContent sub-component for SolidJS reactivity isolation - Fixes FLIP animation scroll preservation (reads-before-writes pattern) - Fixes accordion default expansion mid-load shift (stable initial value) - Uses unfiltered selectedCount in accordion badge - Adds fill-mode: forwards to accordion CSS animation - Adds 8 new tests (1580 total): FLIP rAF callback with call-order assertion, accordion threshold transitions, loading/error states, selectedCount filter invariant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary