fix(api): preserves pending check status when UNSTABLE#56
Merged
wgordon17 merged 3 commits intogordon-code:mainfrom Apr 7, 2026
Merged
fix(api): preserves pending check status when UNSTABLE#56wgordon17 merged 3 commits intogordon-code:mainfrom
wgordon17 merged 3 commits intogordon-code:mainfrom
Conversation
GitHub's mergeStateStatus UNSTABLE means "mergeable with non-passing commit status", which includes both failing AND pending checks. The UNSTABLE override was unconditionally setting checkStatus to "failure", clobbering the correct "pending" state from statusCheckRollup. Guards the override so it only applies when rollup is not pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mergeStateStatus === UNSTABLEoverride so it no longer clobbers a legitimatependingcheck status tofailure— PRs with pending CI now correctly show yellow pulsing dot instead of redhookTimeoutfrom 10s to 30s to prevent DashboardPage test flakiness under pre-push resource pressure