fix(scope): show tracked user items in default involves_me scope#61
Merged
wgordon17 merged 7 commits intogordon-code:mainfrom Apr 9, 2026
Merged
Conversation
The scope filter's isUserInvolved() tier 1 checked whether the main user's login was in surfacedBy, hiding items surfaced only by tracked users. Since surfacedBy is exclusively populated by involves: searches (main user or tracked users), any surfacedBy presence means someone the user chose to track is involved — always relevant. Changes tier 1 from surfacedBy.includes(login) to surfacedBy.length > 0. Monitored repo items (no surfacedBy) still use field-based fallback. Updates 4 tests that modeled tracked user items as community items by using surfacedBy with a non-main-user login — an unrealistic fixture since surfacedBy is only set for tracked user search results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isUserInvolved()checking if the main user's login was insurfacedBy, but bot-only items hadsurfacedBycontaining only the tracked user's loginsurfacedBy.includes(login)toreturn truewhen anysurfacedByentries exist, sincesurfacedByis exclusively populated byinvolves:searches for the main user or tracked users