Allow multiple models in sqlalchemy#30
Conversation
…ry into allow_multiple_models
…cts as requested in issue gorilla-co#24
- Split `apply_odata_query` in two functions to ease rewriting - Add function to create AST (and rewrite if desired) - Add function to apply parsed AST, showing how to manage sqlalchemy's polymorphism
OliverHofkens
left a comment
OliverHofkens
left a comment
There was a problem hiding this comment.
Thanks for contributing this, looks great!
I added one minor linting nitpick, but I might just quickly fix this myself if I have some time today so this can be released soon.
I might also add some test cases on this behavior.
| @@ -1,31 +1,66 @@ | |||
| from typing import List | |||
There was a problem hiding this comment.
The imports aren't organized correctly. We use isort to automate this process, as described in https://github.com/gorilla-co/odata-query/blob/master/CONTRIBUTING.rst#local-development. I did notice that our Github Workflow wasn't configured to run on Pull Requests, otherwise this would've been more clear, sorry! This is improved for future PRs.
There was a problem hiding this comment.
My bad. I did run blake but forgot to run isort. I had some issues with poetry, so I wasn't able to properly test the PR. Please do not hesitate to make any changes you think are necessary, or let me know if it is something I can do.
|
Hey @AndiZeta, any chance you could squash your commits into 1? |
3 participants
See issue #24