Gorse.NET fixes and package updates by IbrahimHabibeh · Pull Request #23 · gorse-io/Gorse.NET

IbrahimHabibeh · 2026-02-07T23:47:01Z

This is a fork of Gorse.NET that I maintain locally. It's updated for .NET 10 and provides some missing implementations for newer Gorse endpoints. Additionally, it fixes a few issues with naming convention and type usage to make it more consistent with Gorse.

…e and class name

Copilot

Pull request overview

Updates the Gorse.NET client library with newer endpoint support and naming/type consistency improvements, alongside framework and package updates.

Changes:

Renames the main client class to GorseClient and updates API partial classes/tests accordingly.
Aligns model naming/types (e.g., TimeStamp → Timestamp, Feedback.Timestamp to DateTime) and expands feedback/recommendation APIs.
Updates target frameworks and bumps RestSharp dependency.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
Gorse.NET/Models/Item.cs	Renames `TimeStamp` to `Timestamp` on `Item`.
Gorse.NET/Models/Feedback.cs	Changes `Timestamp` from `string` to `DateTime`.
Gorse.NET/Gorse.cs	Renames main client type to `GorseClient`.
Gorse.NET/Gorse.NET.csproj	Targets `net9.0` and updates RestSharp reference.
Gorse.NET/API/UsersAPI.cs	Updates partial class to `GorseClient`.
Gorse.NET/API/RecommendationAPI.cs	Adds optional `n` to recommend calls and adds latest endpoint method.
Gorse.NET/API/ItemsAPI.cs	Updates partial class to `GorseClient`.
Gorse.NET/API/FeedbackAPI.cs	Adds upsert feedback support and changes async signature type.
Gorse.NET.Tests/UnitTests/TestItemsAPI.cs	Updates test usage for `Timestamp`.
Gorse.NET.Tests/UnitTests/TestFeedbackAPI.cs	Updates timestamp type usage and async feedback collection type.
Gorse.NET.Tests/GorseTest.cs	Updates test client construction to `GorseClient`.
Gorse.NET.Tests/Gorse.NET.Tests.csproj	Targets `net9.0`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-20T13:02:58Z

Gorse.NET/API/FeedbackAPI.cs

+    /// <summary>
+    /// Insert feedback. Duplicate feedback will have their values summed.
+    /// Use UpsertFeedbackAsync for overwrite semantics.
+    /// </summary>


These XML docs are on the synchronous InsertFeedback method but reference UpsertFeedbackAsync. This is misleading for callers; the docs should reference the synchronous alternative (UpsertFeedback) or mention both sync/async options consistently.

Copilot · 2026-02-20T13:02:59Z

Gorse.NET/API/RecommendationAPI.cs

+    public string[]? GetRecommend(string userId, int? n = 10)
+    {
+        return _client.Request<string[], Object>(Method.Get, $"api/recommend/{userId}?n={n}", null);
+    }


n is nullable but is always appended into the query string; when n == null this produces ?n= which can cause server-side validation errors. Prefer a non-nullable int n = 10, or omit the n query parameter when it’s null (apply the same fix to the async overload).

Copilot · 2026-02-20T13:02:59Z

Gorse.NET/API/RecommendationAPI.cs

+    public Task<List<UserScore>> GetRecommendLatestAsync(int? n = 10)
+    {
+        return _client.RequestAsync<List<UserScore>, object>(Method.Get, $"api/latest?n={n}", null)!;
+    }


GetRecommendLatestAsync is newly introduced but currently has no test coverage (the recommendation tests only exercise GetRecommend*). Add a test that calls this method and asserts the response shape/contents to prevent future breaking changes.

Copilot · 2026-02-20T13:02:59Z

Gorse.NET/API/FeedbackAPI.cs

+    public Result UpsertFeedback(Feedback[] feedbacks)
+    {
+        return _client.Request<Result, Feedback[]>(Method.Put, "api/feedback", feedbacks)!;
+    }
+


New upsert operations were added (UpsertFeedback / UpsertFeedbackAsync), but there are no corresponding tests validating the PUT/overwrite semantics. Please add coverage similar to the existing InsertFeedback tests so regressions in endpoint behavior are caught.

Copilot · 2026-02-20T13:02:59Z

Gorse.NET/Gorse.cs

+public partial class GorseClient
 {
    private readonly RequestClient _client;
-    public Gorse(string endpoint, string apiKey)
+    public GorseClient(string endpoint, string apiKey)
    {


Renaming the public client type from Gorse to GorseClient is a breaking change for all consumers. Consider keeping a Gorse wrapper/alias (optionally marked [Obsolete]) or bumping the package major version to reflect the breaking API change.

Though GorseClient is a better name, but i suggest keep Gorse to avoid break changes.

Gorse.NET/Gorse.NET.csproj

Copilot · 2026-02-20T13:03:00Z

Gorse.NET.Tests/Gorse.NET.Tests.csproj

+    <TargetFramework>net9.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>


The PR description mentions .NET 10, but the test project targets net9.0. Align the test target framework with the intended supported runtime (or update the PR description if net9 is the goal).

Copilot · 2026-02-20T13:03:00Z

Gorse.NET/API/FeedbackAPI.cs

+    /// <summary>
+    /// Upsert feedback. Duplicate feedback will be overwritten (not summed).
+    /// Use InsertFeedbackAsync for additive/sum semantics.
+    /// </summary>


These XML docs are on the synchronous UpsertFeedback method but reference InsertFeedbackAsync. Update the documentation to point to the synchronous InsertFeedback method (or mention both) so callers don’t have to infer the correct API.

Copilot · 2026-02-20T13:03:01Z

Gorse.NET/API/RecommendationAPI.cs

+    public Task<List<UserScore>> GetRecommendLatestAsync(int? n = 10)
+    {
+        return _client.RequestAsync<List<UserScore>, object>(Method.Get, $"api/latest?n={n}", null)!;
+    }


Same issue as above: GetRecommendLatestAsync accepts nullable n but always includes it in the URL, resulting in ?n= when null. Use a non-nullable int n = 10 or conditionally omit the query parameter.

Copilot · 2026-02-20T13:03:01Z

Gorse.NET/API/FeedbackAPI.cs

+    /// Use UpsertFeedbackAsync for overwrite semantics.
+    /// </summary>
+    public Task<Result> InsertFeedbackAsync(List<Feedback> feedbacks)
+    {
+        return _client.RequestAsync<Result, List<Feedback>>(Method.Post, "api/feedback", feedbacks)!;


InsertFeedback takes Feedback[] while InsertFeedbackAsync takes List<Feedback> (and similarly for upsert). This makes the public API inconsistent and forces callers to change collection types depending on sync/async. Consider using the same parameter type across both (or offering overloads, e.g., IEnumerable<Feedback>).

zhenghaoz · 2026-02-20T14:25:33Z

Gorse.NET/Gorse.cs

+public partial class GorseClient
 {
    private readonly RequestClient _client;
-    public Gorse(string endpoint, string apiKey)
+    public GorseClient(string endpoint, string apiKey)
    {


Though GorseClient is a better name, but i suggest keep Gorse to avoid break changes.

IbrahimHabibeh added 6 commits December 14, 2025 14:45

naming and type consistency with RESTful API, differentiated namespac…

6643bf3

…e and class name

pull upstream changes

7689089

Update type usage

bb06a5f

updated to .NET 10

4351c16

Package Update - RestSharp

c8df207

overwrite support for feedbacks

621632c

zhenghaoz requested a review from Copilot February 20, 2026 12:57

Copilot started reviewing on behalf of zhenghaoz February 20, 2026 12:57 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

zhenghaoz requested changes Feb 20, 2026

View reviewed changes

IbrahimHabibeh added 7 commits February 20, 2026 13:12

undo gorse class rename

46a6592

.NET 10 update

d4e1e05

remove nullability for parameter n

8e8ee96

update version to match tested Gorse version

088ccf7

Update insert methods to use IEnumerable<T> as input

ae840bf

.NET 10 and package updates for testing

dfc0407

Update XML docs for consistency

b27dd8f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gorse.NET fixes and package updates#23

Gorse.NET fixes and package updates#23
IbrahimHabibeh wants to merge 13 commits intogorse-io:mainfrom
IbrahimHabibeh:main

IbrahimHabibeh commented Feb 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

zhenghaoz Feb 20, 2026

Uh oh!

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

zhenghaoz Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		<TargetFramework>net9.0</TargetFramework>
		<ImplicitUsings>enable</ImplicitUsings>

Conversation

IbrahimHabibeh commented Feb 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

zhenghaoz Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

zhenghaoz Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants