Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the test infrastructure to use the ml-100k dataset instead of Redis-backed mock data for integration testing. The changes simplify the development and CI setup by replacing Docker Compose with a shell script that sets up a pre-configured Gorse instance with real movie recommendation data.
- Migrated tests from synthetic data to ml-100k dataset validation
- Added
delete_feedbackAPI methods to both sync and async clients - Removed Redis dependency and simplified infrastructure setup
- Version bumped to 0.5.0
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_gorse.py | Refactored all tests to validate against ml-100k dataset instead of creating mock data; added UTC import for proper timezone handling; removed Redis dependency |
| gorse/init.py | Added delete_feedback methods to both sync and async clients for deleting feedback entries |
| test-requirements.txt | Removed redis dependency |
| setup.py | Version bumped from 0.4.10 to 0.5.0 |
| docker-compose.yml | Removed entire Docker Compose configuration |
| config.toml | Removed Gorse configuration file |
| CONTRIBUTING.md | Updated setup instructions to use new shell script instead of Docker Compose |
| .github/workflows/ci.yml | Replaced Docker Compose health check with shell script setup |
| .devcontainer/devcontainer.json | Added new Dev Container configuration |
| .devcontainer/Dockerfile | Added Dev Container Dockerfile |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removed Python 3.10 from the CI workflow matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.