[BUG FIX]: preserve field names without whitespace on decision table column… - #242
Open
cmurphy-navixio wants to merge 1 commit into
Open
Conversation
… import Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing into a decision table node from Excel, the column field mapping in DecisionTableCommandBar.handleDataMapping it strips any characters outside the regex [a-zA-Z0-9\s._] and then lowercases the field mappings. In the case the field already has camel casing and has no spaces the result for input columns it breaks mappings for between the column and an input json path. A similar thing happens for the output columns
For example:
As a result, re-importing a sheet could silently break the binding between columns and the fields they reference.
This fix only applies the normalization when the mapped value actually contains whitespace (i.e., it's a human-readable label that needs converting into a field name). If the trimmed value has nowhitespace, treat it as an already-valid field expression and use it as-is.
This applies to both input and output column mapping.