Refactor entry and operation management with enhanced comparison logic#153
Merged
Conversation
- Added `compareEntry` and `compareOperation` functions to handle comparison logic for entries and operations. - Created unit tests for both comparers to ensure correct behavior under various scenarios. - Updated `EntryFactory` to utilize the new comparers for updating entries in transactions. - Refactored entry and operation DTOs to include necessary fields for updates. - Modified repository interfaces and implementations to replace soft delete methods with void methods. - Updated transaction use case to handle entry updates more effectively. - Enhanced domain entities with new methods for updating descriptions and operations. - Adjusted tests across the application to reflect changes in entry and operation handling.
…updater for entry management
…ods for better clarity and functionality
…nction to support currency parameter
…lifying entry creation logic
…, enhance entry creation and update logic
…ty with improved metadata handling
…ged entries in EntryUpdater
…ance error handling
gorushkin
changed the base branch from
main
to
144-refactoring-updatetransactionusecase
gorushkin
merged commit e11689a
into
144-refactoring-updatetransactionusecase
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the
UpdateTransactionUseCaseandEntryFactoryfor improved entry and operation management. Implement comparers for entries and operations, along with comprehensive tests. Introduce theEntriesServicefor better entry handling and update logic, while enhancing metadata management and simplifying entry creation. Adjust related tests to ensure accuracy and functionality.