fix(web): fix funnel edit page and metrics display#35
Merged
Conversation
- Fix EditFunnel showing "Funnel Not Found" by passing funnelId as prop instead of using useParams() (no matching Route param was defined) - Fix funnel card metrics not loading due to invalid date format in API query (was 'yyyy-MM-dd HH:mm:ss', backend expects ISO 8601) - Add step conversion pipeline to funnel cards showing step names, completions, and conversion rates - Add error state handling for failed metrics queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditFunneluseduseParams()to getfunnelId, but no matching<Route path=":funnelId/edit">existed —funnelIdwas alwaysundefined. Now parsed from the URL and passed as a prop (same pattern asFunnelDetail).formatDateForAPIproduced"2026-03-14 11:00:00"but the backend expects ISO 8601 ("2026-03-14T11:00:00.000Z"). The metrics query string deserialization failed, so cards showed nothing. Fixed by usingdate.toISOString().page_view 1,234 → signup 890 (72%)).Test plan
/projects/{slug}/analytics/funnels— cards should show metrics and step pipeline/projects/{slug}/analytics/funnels/{id}/edit— should load the edit form (not "Funnel Not Found")