fix(skills): quote argument-hint so Copilot CLI 1.0.65 parses it as string#33
Open
thejesh23 wants to merge 1 commit into
Open
Conversation
…tring The `argument-hint:` frontmatter field on eight SKILL.md files was written as an unquoted bracketed value (e.g. `[optional ADR topic]`). YAML interprets unquoted `[...]` as a flow sequence, so the field parsed as an array instead of a string. Copilot CLI 1.0.65 tightened its schema to require `argument-hint` to be a string, which now rejects these files at load time. Claude Code currently tolerates the array form but the same root cause is tracked upstream in anthropics/claude-code#22161. Fix by quoting each affected value so YAML parses it as a plain string. The migrate skill hint contains inner double quotes, so it uses single-quoted YAML to avoid escape gymnastics. No behavior change intended: the rendered hint text remains identical; only the YAML type of the field changes from sequence to string. Refs: Egonex-AI/Understand-Anything#540, anthropics/claude-code#22161
📝 WalkthroughWalkthroughThis PR updates the ChangesSkill Metadata Quoting
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Tracking issue: #34 — captures the bug diagnosis and reproducer separately for anyone searching the repo who lands there before this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eight
.claude/skills/*/SKILL.mdfiles declareargument-hint:with an unquoted bracketed value, e.g.:YAML parses unquoted
[...]as a flow sequence, so this field is loaded as an array (["optional ADR topic"]) rather than a string.Why this matters now
argument-hintto be a string. It now rejects the array form outright, so any user running these skills through the Copilot CLI sees the skill fail to load.Fix
Quote each affected value so YAML parses it as a plain string. Rendered hint text is unchanged.
adr-writer/SKILL.md[optional ADR topic]"[optional ADR topic]"commit/SKILL.md[optional commit message hint]"[optional commit message hint]"detach/SKILL.md[optional scope hint]"[optional scope hint]"guard-writer/SKILL.md[optional guard topic]"[optional guard topic]"init/SKILL.md[optional setup scope]"[optional setup scope]"migrate/SKILL.md[optional scope hint, e.g. "focus on database decisions"]'[optional scope hint, e.g. "focus on database decisions"]'rfc-writer/SKILL.md[optional RFC topic]"[optional RFC topic]"wi-writer/SKILL.md[optional work-item topic]"[optional work-item topic]"migrate/SKILL.mduses single-quoted YAML because the value contains inner double quotes; single quotes avoid the need for escapes and keep the rendered text byte-for-byte identical.The four skills that use angle-bracket placeholders (
discuss,gov,quick,spec, e.g.argument-hint: <what-to-do>) are already valid YAML plain scalars and are intentionally left alone.decision-analysis/SKILL.mdhas noargument-hintand is unaffected.Test plan
grep -rHn '^argument-hint:' --include='*.md') enumerates all 12 SKILL.md files with the field.type(argument-hint) is str— passes for all 12 after this change (was failing for the 8 files above).argument-hintfield.References
argument-hintSummary by CodeRabbit