-
Notifications
You must be signed in to change notification settings - Fork 6
fix: page respects paginator max size #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c5f65b4
fix: page respects paginator max size
klaidliadon 3eb43d5
refactor: simplify paginator options handling and improve pagination …
klaidliadon d74d872
fix: ensure default size does not exceed max size in paginator options
klaidliadon e62f09b
fix: handle default and max sizes in paginator options and improve pa…
klaidliadon 5db2fa1
fix: streamline paginator initialization in pagination edge cases test
klaidliadon abe7931
fix: ensure max size is not less than default size in paginator options
klaidliadon 6b9c2bd
linter pass
klaidliadon 81357e9
fix: replace assert.True with assert.Equal and assert.NotZero for cla…
klaidliadon 4273b9b
fix: update paginator options to clarify default and max size behavior
klaidliadon afdd6ea
fix: simplify filter checks in UpdateRecordColumns and TraversalsByNa…
klaidliadon 520d0a1
linter pass
klaidliadon 1f0621f
fix: implement default settings for PaginatorOptions and Page
klaidliadon 8c31ac4
fix: refactor pagination methods to remove PaginatorOptions dependency
klaidliadon 726813a
fix test
klaidliadon 3b218c7
fix: replace manual assertions with testify assertions in reflect tests
klaidliadon 515735a
fix: refactor paginator to use PaginatorSettings and update related t…
klaidliadon bdb585c
fix: update paginator option functions for clarity and consistency
klaidliadon 3587061
fix: refactor pagination test to use constants for size and sort options
klaidliadon d50a9b5
fix: simplify length assertions in pagination test
klaidliadon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.