set row_limit to NULL when printing differences#136
Closed
dwoollacott wants to merge 1 commit intogowerc:masterfrom
Closed
set row_limit to NULL when printing differences#136dwoollacott wants to merge 1 commit intogowerc:masterfrom
dwoollacott wants to merge 1 commit intogowerc:masterfrom
Conversation
Owner
|
Hey @dwoollacott - I'm not sure this is the route I want to go down, as mentioned by @kieranjmartin in theory if the keys are mismatched this can produce a lot of unnecessary content particularly for large datasets. Likewise it also potentially breaks backwards compatibility as this has been the default for a long while. That being said I created #140 in hopes of addressing the issue. That is I added a "file" argument to the print function where you can use the Please let me know if this meets you needs or not. |
Author
|
Hello @gowerc , thanks for looking into this. Yes, your explanation makes sense and fixes the issue. |
Owner
|
ty - will close this in favour of #140 then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.