-
Notifications
You must be signed in to change notification settings - Fork 2
Fix async hooks for Codex #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a9928d8
Make plugin hook helpers self-contained
lukelabonte 8855dda
Migrate legacy commands to skills
lukelabonte 59e4633
Fix background hook ownership and release metadata
lukelabonte e591d41
Validate background hook owner PID
lukelabonte 0ac8f0e
Restore SwiftUI skill metadata
lukelabonte d84e304
Remove common hook template copies
lukelabonte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| name: update-plugin | ||
| description: Use when updating, versioning, tagging, or releasing a plugin in this Claude Code-compatible plugin marketplace. | ||
| --- | ||
|
|
||
| # Update Plugin | ||
|
|
||
| Use this workflow when preparing a plugin update in this marketplace. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. Inspect the diff. | ||
| - If `common/` changed, every plugin is affected. | ||
| - Run `scripts/sync-plugin-common.py` before editing versions so each plugin package has current copied helpers. | ||
| - If `common/hooks.json` changed, propagate the hook shape to each plugin's `hooks/hooks.json` while preserving plugin-specific command names. | ||
| 2. Identify the plugin or plugins to update. | ||
| - Ask only if the changed plugin is unclear from the diff. | ||
| - Suggest a semantic version bump from the change scope. | ||
| 3. Update version metadata. | ||
| - Update `<PluginDir>/.claude-plugin/plugin.json`. | ||
| - Update the matching entry in `.claude-plugin/marketplace.json`. | ||
| 4. Document the change. | ||
| - Update the plugin README changelog. | ||
| - Add a matching entry to the plugin `info.json` `versions` array. | ||
| - If skills were added, removed, or renamed, update the plugin `info.json` `skills` array. | ||
| - If legacy command prompts are present, migrate them to skills before release. | ||
| 5. Verify. | ||
| - Run `scripts/sync-plugin-common.py --check`. | ||
| - Run `python3 -m unittest discover -s tests -v`. | ||
| - Confirm plugin manifest, marketplace, README, and `info.json` versions match. | ||
| 6. Commit and tag after the commit lands. | ||
| - Tag format: `{PluginName}--v{version}`. | ||
| - Push the tag with `git push origin {PluginName}--v{version}`. | ||
| - If multiple plugins were bumped, create and push one tag per plugin. | ||
|
|
||
| ## Notes | ||
|
|
||
| - The installed plugin package must be self-contained. Do not edit copied `*/common/` files by hand; edit root `common/` and rerun `scripts/sync-plugin-common.py`. | ||
| - JSON files must remain valid. | ||
| - Plugin names must match folder names exactly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| #!/usr/bin/env python3 | ||
| # Generated from common/detect_xcode_mcp.py by scripts/sync-plugin-common.py. Do not edit this copy; edit common/detect_xcode_mcp.py and rerun scripts/sync-plugin-common.py. | ||
| """Detect whether Xcode's native MCP server is available.""" | ||
|
|
||
| import subprocess | ||
|
|
||
|
|
||
| def detect_xcode_mcp() -> dict: | ||
| """Check if Xcode MCP bridge is installed and likely active. | ||
|
|
||
| Returns dict with: | ||
| xcode_mcp_installed: xcrun --find mcpbridge succeeds | ||
| xcode_running: Xcode process is running | ||
| mcpbridge_running: mcpbridge process is running | ||
| xcode_mcp_likely: installed AND (xcode OR bridge running) | ||
| """ | ||
| result = { | ||
| "xcode_mcp_installed": False, | ||
| "xcode_running": False, | ||
| "mcpbridge_running": False, | ||
| "xcode_mcp_likely": False, | ||
| } | ||
|
|
||
| # Check if mcpbridge binary exists (Xcode 26.3+) | ||
| try: | ||
| subprocess.run( | ||
| ["xcrun", "--find", "mcpbridge"], | ||
| capture_output=True, timeout=5 | ||
| ).returncode == 0 and result.update({"xcode_mcp_installed": True}) | ||
| except Exception: | ||
| pass | ||
|
|
||
| if not result["xcode_mcp_installed"]: | ||
| return result | ||
|
|
||
| # Check if Xcode is running | ||
| try: | ||
| if subprocess.run( | ||
| ["pgrep", "-x", "Xcode"], | ||
| capture_output=True, timeout=3 | ||
| ).returncode == 0: | ||
| result["xcode_running"] = True | ||
| except Exception: | ||
| pass | ||
|
|
||
| # Check if mcpbridge is running | ||
| try: | ||
| if subprocess.run( | ||
| ["pgrep", "-f", "mcpbridge"], | ||
| capture_output=True, timeout=3 | ||
| ).returncode == 0: | ||
| result["mcpbridge_running"] = True | ||
| except Exception: | ||
| pass | ||
|
|
||
| result["xcode_mcp_likely"] = ( | ||
| result["xcode_running"] or result["mcpbridge_running"] | ||
| ) | ||
| return result |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MarvinOutputStyle, iOSSimulator, and PluginBase get patch bumps because their package contents changed from symlinked
commondirectories to generated committed copies. SwiftScaffolding and XcodeBuildTools already had branch-local bumps, so the common-copy note is folded into those existing release entries instead of bumping them twice.