fix(shader): correct pI1→pI2 variable in dual-issue decode stats#338
Open
eunseo9311 wants to merge 1 commit intogpgpu-sim:devfrom
Open
fix(shader): correct pI1→pI2 variable in dual-issue decode stats#338eunseo9311 wants to merge 1 commit intogpgpu-sim:devfrom
eunseo9311 wants to merge 1 commit intogpgpu-sim:devfrom
Conversation
In shader_core_ctx::decode() (shader.cc:911-912), the operand type check for the second decoded instruction incorrectly referenced pI1 instead of pI2, causing m_num_INTdecoded_insn to be updated based on the first instruction's type when classifying the second. The bug is latent: it only triggers when two instructions are decoded in the same cycle with differing operand types (e.g., one INT, one FP). Simulation behavior is unaffected; only decode statistics are corrected.
8d76c4f to
e495815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an incorrect variable reference in
shader_core_ctx::decode()that causes wrong instruction type statistics to be recorded for the second instruction in dual-issue scenarios.Problem
In
shader.cclines 911–912, the operand type check for the second decoded instruction (pI2) incorrectly referencespI1:This causes
m_num_INTdecoded_insnto be incremented based onpI1's operand type when classifyingpI2, silently producing incorrect decode statistics for dual-issued instructions. The bug is latent — it only manifests when both instructions are decoded in the same cycle and their operand types differ.Fix
Impact
m_num_INTdecoded_insn,m_num_FPdecoded_insn) will now correctly reflect the second instruction's operand type in dual-issue scenariosTesting
Verified with Rodinia 2.0
hotspotbenchmark on GTX1080Ti config. Simulation output log is identical; only per-SM decode stat counters change for workloads with dual-issued mixed INT/FP instruction pairs.