Removes start-of-line matching restriction for kernel_name in get_stats.py#8
Open
SerinaTan wants to merge 1 commit intogpgpu-sim:masterfrom
Open
Removes start-of-line matching restriction for kernel_name in get_stats.py#8SerinaTan wants to merge 1 commit intogpgpu-sim:masterfrom
SerinaTan wants to merge 1 commit intogpgpu-sim:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the benchmark happens to use printf() upon kernel completion without '\n', "kernel_name = blahblah" might not appear at the start of the line, in which case re.match() will not find the kernel and the produced table would have mismatched data. Changing it to re.search() to allow matching in the middle of a line.