Skip to content

Fix Readme and Change variant width, height, depth to float64 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eylea wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Readme and Change variant width, height, depth to float64 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba5fa76
Fix readme to include map[string]string{}
zjom Mar 17, 2024
117f3cf
change variants w,h,d to float
zjom Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func main() {
// for app development, you need to provide arguments
// for CLI and other web apps you can use empty strings
client := bigcommerce.NewClient("** my store's hash like '123abcdefg' **", "**my X-Auth-Token generated in BigCommerce admin**")
products, err := client.GetAllProducts()
products, err := client.GetAllProducts(map[string]string{})
if err != nil {
log.Fatalf("Error while getting products: %v", err)
}
Expand Down
6 changes: 3 additions & 3 deletions products.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ type Product struct {
RetailPrice float64 `json:"retail_price,omitempty"`
MapPrice float64 `json:"map_price,omitempty"`
Weight float64 `json:"weight,omitempty"`
Width int `json:"width,omitempty"`
Height int `json:"height,omitempty"`
Depth int `json:"depth,omitempty"`
Width float64 `json:"width,omitempty"`
Height float64 `json:"height,omitempty"`
Depth float64 `json:"depth,omitempty"`
IsFreeShipping bool `json:"is_free_shipping,omitempty"`
FixedCostShippingPrice float64 `json:"fixed_cost_shipping_price,omitempty"`
CalculatedWeight float64 `json:"calculated_weight,omitempty"`
Expand Down