Skip to content

Numba Optimizations #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DO-Ui wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Numba Optimizations #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
202a4d7
Numba Optimizations
DO-Ui Feb 19, 2026
056871b
In-place numba optimizations
DO-Ui Feb 20, 2026
949d633
Annotations Only Version
DO-Ui Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions cvtModel/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,15 @@
"scipy",
"matplotlib",
"pandas",
"pydantic"
"pydantic",
"numba"
],
extras_require={"dev": [
"black",
"flake8",
"pytest",
"coverage"
]},
extras_require={
"dev": [
"black",
"flake8",
"pytest",
"coverage"
],
},
)
4 changes: 3 additions & 1 deletion cvtModel/src/cvt_simulator/models/slip_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from cvt_simulator.constants.constants import (
RUBBER_ALUMINUM_STATIC_FRICTION,
)
from cvt_simulator.utils.numba_utils import maybe_njit


class SlipModel:
Expand Down Expand Up @@ -152,8 +153,9 @@ def calculate_t_max(self, state: SystemState) -> tuple[float, float]:
secondary_t_max = max(0, secondary_t_max)
return primary_t_max, secondary_t_max

@staticmethod
@maybe_njit(cache=True, fastmath=True)
def _relative_speed(
self,
primary_angular_velocity: float,
secondary_angular_velocity: float,
cvt_ratio: float,
Expand Down
16 changes: 16 additions & 0 deletions cvtModel/src/cvt_simulator/utils/numba_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
try:
from numba import njit

NUMBA_ENABLED = True

def maybe_njit(*args, **kwargs):
return njit(*args, **kwargs)

except ImportError: # pragma: no cover - exercised when numba is installed
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pragma comment is misleading. It states "exercised when numba is installed" but this is the except ImportError block, which executes when numba is NOT installed. The comment should either be "exercised when numba is not installed" or be moved to line 1-7 which is exercised when numba is installed.

Suggested change
except ImportError: # pragma: no cover - exercised when numba is installed
except ImportError: # pragma: no cover - exercised when numba is not installed

Copilot uses AI. Check for mistakes.
NUMBA_ENABLED = False

def maybe_njit(*args, **kwargs):
def decorator(func):
return func

return decorator