Skip to content

Index Line Zoom#430

Open
camdnnn wants to merge 2 commits into
developfrom
index-line-zoom-fix
Open

Index Line Zoom#430
camdnnn wants to merge 2 commits into
developfrom
index-line-zoom-fix

Conversation

@camdnnn
Copy link
Copy Markdown
Collaborator

@camdnnn camdnnn commented Apr 11, 2026

Description
Fixed bug where index lines where being displayed outside chart bounds when after zooming

Changes
List the main changes made in this PR:

  • Hide index line when outside chart bounds
  • Fix index to not go outside limits

Screenshots (if applicable)
Add screenshots to show the changes (if any).

Additional Notes
Any other things of note, could include bugs, new warnings, or other things changed that do not concern the main PR content.

@camdnnn camdnnn self-assigned this Apr 11, 2026
@camdnnn camdnnn added bug Something isn't working frontend To do with the frontend of the project labels Apr 11, 2026
Copilot AI review requested due to automatic review settings April 11, 2026 18:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an index-overlay rendering issue during chart zoom by preventing the index indicator from being displayed outside the visible (zoomed) plot area, and aligns replay progress indexing with the actual emitted datapoint.

Changes:

  • Adjust replay progress events to emit the processed datapoint’s index (instead of the next index).
  • Hide the index line and dots when the computed x-position falls outside the zoomed grid bounds.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
frontend/src/utils/ReplayController.ts Emits currentIndex consistent with the data point emitted during playback.
frontend/src/components/graph2D/indexOverlay/IndexOverlay.tsx Adds in-bounds check to hide index visuals when outside the zoomed chart grid.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/src/components/graph2D/indexOverlay/IndexOverlay.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend To do with the frontend of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants