Index Line Zoom#430
Open
camdnnn wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an index-overlay rendering issue during chart zoom by preventing the index indicator from being displayed outside the visible (zoomed) plot area, and aligns replay progress indexing with the actual emitted datapoint.
Changes:
- Adjust replay progress events to emit the processed datapoint’s index (instead of the next index).
- Hide the index line and dots when the computed x-position falls outside the zoomed grid bounds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/utils/ReplayController.ts | Emits currentIndex consistent with the data point emitted during playback. |
| frontend/src/components/graph2D/indexOverlay/IndexOverlay.tsx | Adds in-bounds check to hide index visuals when outside the zoomed chart grid. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed bug where index lines where being displayed outside chart bounds when after zooming
Changes
List the main changes made in this PR:
Screenshots (if applicable)
Add screenshots to show the changes (if any).
Additional Notes
Any other things of note, could include bugs, new warnings, or other things changed that do not concern the main PR content.