Draft
Conversation
pyphilia
requested changes
Jul 2, 2025
Contributor
pyphilia
left a comment
pyphilia
left a comment
There was a problem hiding this comment.
Thanks for this PR, let me know if we need to discuss on some points!
Is it necessary to setup the github credentials locally? Or is there an easy way to bypass this locally? If it's too hacky to avoid the setup, let's keep it like that.
spaenleh
force-pushed
the
1907-github-oauth-admin
branch
from
20c6491 to
8606f6b
Compare
pyphilia
requested changes
Jul 7, 2025
| authenticatedAdmin.register(queueDashboardPlugin); | ||
| }), | ||
| ); | ||
| }; |
Contributor
There was a problem hiding this comment.
Should all those endpoints have a schema?
pyphilia
reviewed
Jul 7, 2025
Comment on lines
+23
to
+26
| // TODO: this tests fails now because passport registration has been moved to inside the core registration and we can not register a route there, | ||
| // all top level routes do not use passport. | ||
| // move this test closer to matchOne | ||
| // other preHandlers are tested in plugin.test.ts |
Contributor
There was a problem hiding this comment.
Does it work? Remove comment?
pyphilia
requested changes
Jul 7, 2025
| it('No Whitelist', async () => { | ||
| handler.mockImplementation(shouldBeActor(member)); | ||
| const response = await app.inject({ path: MOCKED_ROUTE }); | ||
| // console.log(await response.json()); |
Comment on lines
+60
to
+71
| await app.register(fp(openapiPlugin)); | ||
| await app.register(fp(schemaRegisterPlugin)); | ||
|
|
||
| // db should be registered before the dependencies. | ||
| await app.register(fp(databasePlugin)); | ||
|
|
||
| // register some dependencies manually | ||
| registerDependencies(app.log); | ||
|
|
||
| await app.register(fp(metaPlugin)); | ||
| // register the core app | ||
| app.register(fp(coreApp)); |
Contributor
There was a problem hiding this comment.
What was important to include or not compared to the main app? Add comments.
Closed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1907
TODO: add tests