Open
Conversation
* fix: setup sentry for CJS * fix: make small changes to config * fix: send sourcemaps to sentry on build inside docker * fix: make requested changes fix: duplicated env in build image fix: add sentry token to dev deploy fix: send sourcemaps separately and do not include sourcemaps in prod code
spaenleh
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This records the sentry instrumentation code changes.
It looks like this code change when deployed to AWS does not start fast enough for the ALB Health checks to succeed so it gets killed.
We need to find why there looks to be such a slow down when adding sentry.
We could maybe use the late initialization technique which would allow the server to be responsive sooner. But even in that case it might be that the auto-instrumentation that is done is too much for the server start.
Maybe we need to increase the memory and cpu resources ? Maybe we should try to bundle the code ? But this probably means having to re-write parts of the code, in that case maybe it is too much work and we should focus on porting/migrating the code to elixir instead ? Not sure.