Open
Conversation
jrg94
approved these changes
Dec 16, 2025
jrg94
left a comment
jrg94
left a comment
There was a problem hiding this comment.
Really nice work! Only issues I saw were in the abstract class.
| /** | ||
| * Queue of Strings to represent the values of each input. | ||
| */ | ||
| private Queue<String> inputs = new Queue1L<String>(); |
There was a problem hiding this comment.
The abstract class shouldn't have any variables. If you need these values here, you need a getter in the kernel to access them.
| * @ensures {@code <activate> = true || false} | ||
| * @return whether the neuron has fired. | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
You also don't need to contracts because they're inherited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.