fix: correct ec2-install.sh help text, typos, and license handling#29
Merged
Conversation
Found while testing the AWS EC2 quickstart end to end. - Help example referenced ./install.sh; the script is ec2-install.sh. - "tested with Ubuntu 24.04" -> 26.04, matching the quickstart guide. - Post-install message typo: setting.gradle.kts -> settings.gradle.kts. - -v/--version printed nothing: it referenced $Script_Version instead of the defined $SCRIPT_VERSION. - License path: drop the hard-coded ./ prefix so an absolute --license path also works (previously only a relative path resolved correctly).
The Generate SHA256 Checksum workflow did not run on the PR, so update the checksum manually to keep it in sync with the script.
The Generate SHA256 Checksum workflow was not updating the checksum on PRs. Fix it so it regenerates and commits ec2-install.sh.sha256 onto the PR branch whenever the script changes: - Add `permissions: contents: write` so the workflow can push. - Check out the PR head branch (`ref: github.head_ref`) instead of the detached merge ref, so the commit can be pushed back to the PR. - Generate the checksum from inside AWS/EC2 so the file records the bare `ec2-install.sh` name (the guide runs `sha256sum -c` from the working dir; a path-qualified entry would fail validation). - Only commit when the checksum actually changed, to avoid failing on a no-op.
Validated end to end: get-helm-4 installs Helm 4.2.2 and the Develocity standalone chart deploys cleanly (10/10 pods ready, /ping UP). Helm 4 is within Develocity's supported range. Regenerate the checksum to match the new script.
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
pio-kol
commented
Jun 23, 2026
pio-kol
commented
Jun 23, 2026
pio-kol
commented
Jun 23, 2026
svx
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to the EC2 quickstart install script, found while testing the AWS EC2 quickstart end to end (Develocity 2026.2).
-hexample referenced./install.sh; the script isec2-install.sh.-v/--versionprinted nothing. It referenced$Script_Version, but the variable is$SCRIPT_VERSION(also clears the shellcheck SC2034/SC2154 warnings)../prefix in the Helm--set-fileargument so an absolute--licensepath works; the documented relative path still resolves.The
ec2-install.sh.sha256checksum is regenerated automatically by the "Generate SHA256 Checksum" workflow on this PR.Related docs fix: gradle/dv-docs#2036 — findings: gradle/dv-docs#2037