Skip to content
This repository was archived by the owner on Jun 5, 2026. It is now read-only.

fix: use format string in Fatalf to fix go vet error#71

Merged
simonswine merged 1 commit into
mainfrom
fix/non-constant-fatalf
May 29, 2026
Merged

fix: use format string in Fatalf to fix go vet error#71
simonswine merged 1 commit into
mainfrom
fix/non-constant-fatalf

Conversation

@simonswine

Copy link
Copy Markdown
Contributor

Problem

go vet (run as part of go test) now rejects non-constant format strings passed to Fatalf. This caused the CI workflow to fail on both amd64 and arm64 matrix jobs:

relay/remotequeue_flush_test.go:31:14: non-constant format string in call to (*testing.common).Fatalf
FAIL	github.com/pyroscope-io/pyroscope-lambda-extension/relay [build failed]

Fix

Replace string concatenation with a proper format string:

// before
j.t.Fatalf("should be still working... " + j.name)

// after
j.t.Fatalf("should be still working... %s", j.name)

@simonswine simonswine marked this pull request as ready for review May 29, 2026 12:55
@simonswine simonswine requested a review from a team as a code owner May 29, 2026 12:55
@simonswine simonswine merged commit b1c8ca5 into main May 29, 2026
12 checks passed
@simonswine simonswine deleted the fix/non-constant-fatalf branch May 29, 2026 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants